Skip to content

Refactor: Modular test_identity_pool.py with full coverage and fixture setup #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cureprotocols wants to merge 18 commits into from
Closed

Refactor: Modular test_identity_pool.py with full coverage and fixture setup #1727

cureprotocols wants to merge 18 commits into from

Conversation

@cureprotocols
Copy link

@cureprotocols cureprotocols commented Apr 4, 2025

✅ Highlights:

  • Modular test coverage across all identity pool credential scenarios
  • Full test structure with clearly defined sections:
    • I1: Credential creation via from_info()
    • I2: Credential creation via from_file()
    • I3: Subject token source variants (text, JSON, supplier)
    • I4: Constructor validation (error handling)
    • I5: Token + impersonation URL overrides
    • I6: Simulated credential refresh with monkey-patched token

🧩 Includes:

  • make_credentials() fixture for DRY, scalable test patterns
  • Clean UTF-8 encoding across test files
  • tests/README.md documentation for clarity and contributor onboarding

cureprotocols and others added 18 commits April 2, 2025 17:40
fix(types): add type annotations to exceptions module for Mypy strict…
358dc17 
… mode
feat(transport): add typed HTTP request interface in _requests_base.py
2ee47a6
fix(types): add full type annotations and docstrings to transport ini…
6c80025 
…t module
@cureprotocols
Update and rename README.rst to README.md
94f5c4f 
Swapped from reStructuredText to Markdown for improved readability, badge support, and contributor clarity.

This version of the README:
- Retains full respect and gratitude for the original authors.
- Clarifies project goals and roadmap.
- Adds visual indicators for project health and openness to contributors.
@cureprotocols
Update README.md
78406f1
@cureprotocols
Update README.md
547358d
@cureprotocols
Fix: Restore test collection for credentials and mock tests
d8fb709
@cureprotocols
Chore: Normalize line endings and prevent CRLF issues
823c676
@cureprotocols
Add CI for Python matrix
8c4fa00
@cureprotocols
Add full CI pipeline with lint, format check, tests, coverage + Codecov
8cff1f8
@cureprotocols
WIP: prepare for rebase with upstream main
a3f9193
@cureprotocols
Fix Python matrix version: replace 3.1 with 3.10
83998b3
@cureprotocols
Finalize CI pipeline with Codecov and linting
4c5eb6a
@cureprotocols
Trigger CI to verify Python matrix
4c761e8
@cureprotocols
Fix: Use README.md as long_description in setup.py
9725a46
@cureprotocols
Trigger CI after setup.py fix
a034886
@cureprotocols
✅ Complete test_jwt.py refactor with mock jwt.encode and expiry logic
9aaae24
@cureprotocols
✅ Modular test_identity_pool.py with full I1–I6 coverage and test docs
19e03cc
@cureprotocols cureprotocols requested review from a team as code owners April 4, 2025 17:31
@google-cla
Copy link

google-cla bot commented Apr 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chalmerlowe
Copy link
Contributor

chalmerlowe commented Dec 22, 2025

This appears to be an autogenerated PR. Closing. For some specific examples of why PRs posted by this account (cureprotocol) appear to be fraudulent, see links below.

This PR links to an issue #1508 that appears to have nothing to do with the need for type hinting. It is part of a large collection of PRs issued by the same entity at the same time.

Other examples of PRs that have significant issues:
#1712 (comment)
#1711 (comment)
#1717 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cureprotocols @chalmerlowe